HTTPCLIENT-2356: Extend Auth API and authentication Logic to enable m…#614
HTTPCLIENT-2356: Extend Auth API and authentication Logic to enable m…#614ok2c merged 1 commit intoapache:masterfrom
Conversation
|
@stoty Your changes are mostly intact. I folded |
|
Thank you @ok2c . Using a default method instead of a new interface is a definite improvement over my version. Two small issues:
|
|
I was also planning to revert the disabled API check maven plugin before commit. |
|
@stoty Commit message and log statements have been corrected. Please do another pass. |
|
I am going to merge the PR later today unless someone objects. @michael-o Please do a post-commit review. If you see anything wrong with the change-set I will revert it. |
|
Will review this night |
httpclient5/src/main/java/org/apache/hc/client5/http/auth/AuthExchange.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java
Outdated
Show resolved
Hide resolved
…utual authentication
|
@michael-o Corrected. Please do another pass. |
…utual authentication