Skip to content

Sort constraints for deterministic order and stability #6342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zabetak wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Draft

Sort constraints for deterministic order and stability #6342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...e/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1878,6 +1878,9 @@ public List<SQLForeignKey> getForeignKeys(String catName, String parent_db_name,
if (queryText.endsWith("AND")) {
queryText = queryText.substring(0, queryText.length()-3);
}
queryText += """
ORDER BY %1$s."CONSTRAINT_NAME" ASC, %1$s."POSITION ASC"
""".formatted(KEY_CONSTRAINTS);
List<String> pms = new ArrayList<String>();
pms.add(catName);
if (foreign_db_name != null) {
Expand Down
1 change: 1 addition & 0 deletions ...etastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11618,6 +11618,7 @@ private List<SQLForeignKey> getForeignKeysViaJdo(String catName, String parentDb
if (foreignDbName != null) {
params.add(foreignDbName);
}
query.setOrdering("constraintName ascending, position ascending");
constraints = (Collection<?>) query.executeWithArray(params.toArray(new String[0]));

pm.retrieveAll(constraints);
Expand Down