Validate internal links during build#94
Draft
thomasrebele wants to merge 1 commit intoapache:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR imports the link validator from https://www.veriphor.com/articles/link-and-image-render-hooks/.
Currently many of the links are broken, so I set it to warning. The link validator said that no ref shortcuts should be used. So these would need to be updated first:
The links created by the ref shortcuts are working. The link validator just prints a false warning. So we could merge the link validator, and remove the ref shortcuts in a separate PR.
Comparison:
{{< ref "hive-on-tez" >}}resolves todevelopment/desingdocs/hive-on-tez/){{< ref "#configuring-hive" >}}/ "Configuring hive" in the configuration properties, is broken, however, there is no warning){{< ref "..." >}}with{{% ref "..." %}}