-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19790. Updating Minimum Required Maven Version For Hadoop Build #8214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ Requirements: | |
|
|
||
| * Unix System | ||
| * JDK 17 | ||
| * Maven 3.3 or later | ||
| * Maven 3.9.11 or later | ||
| * Boost 1.86.0 (if compiling native code) | ||
| * Protocol Buffers 3.25.5 (if compiling native code) | ||
| * CMake 3.19 or newer (if compiling native code) | ||
|
|
@@ -63,7 +63,11 @@ Refer to dev-support/docker/Dockerfile): | |
| $ sudo apt-get update | ||
| $ sudo apt-get -y install openjdk-17-jdk | ||
| * Maven | ||
| $ sudo apt-get -y install maven | ||
| Most package managers do not install required version of Maven i.e. 3.9.11 or later. | ||
| Following commands download and install Maven manually | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| $ curl -L https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.11/apache-maven-3.9.11-bin.tar.gz > apache-maven-3.9.11-bin.tar.gz | ||
| $ tar -zxvf apache-maven-3.9.11-bin.tar.gz -C /opt | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add a checksum/signature validation stage if we are putting in code for people to run, or at least recommend it. curl -L https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.11/apache-maven-3.9.11-bin.tar.gz.asc > apache-maven-3.9.11-bin.tar.gz.asc
curl -L https://downloads.apache.org/maven/KEYS > KEYS
gpg --import KEYS
gpg --verify apache-maven-3.9.11-bin.tar.gz.asc
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @steveloughran, if you look at the context, no installation does such verification. can we make the guide simple to match the context for now? later we can consider Maven Wrapper https://maven.apache.org/tools/wrapper/, then
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, if mvnw is listed as the install mechanism, it's a lot simpler to detail as it does the validation. Docs can just say "use an up to date version of maven; the mvnw command will download one and validate it before execution" |
||
| $ sudo ln -s /opt/apache-maven-3.9.11/bin/mvn /usr/bin | ||
| * Native libraries | ||
| $ sudo apt-get -y install build-essential autoconf automake libtool cmake zlib1g-dev pkg-config libssl-dev libsasl2-dev | ||
| * GCC 9.3.0 | ||
|
|
@@ -583,7 +587,7 @@ Requirements: | |
|
|
||
| * Windows 10 | ||
| * JDK 17 | ||
| * Maven 3.3 or later (maven.apache.org) | ||
| * Maven 3.9.11 or later (maven.apache.org) | ||
| * Boost 1.86.0 (boost.org) | ||
| * Protocol Buffers 3.25.5 (https://github.com/protocolbuffers/protobuf/tags) | ||
| * CMake 3.19 or newer (cmake.org) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with