fix(security): disclose ReDoS risk for dataset filter reg#160
Open
fix(security): disclose ReDoS risk for dataset filter reg#160
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ECharts security handbook (Chinese + English) to explicitly disclose a potential ReDoS risk when dataset.transform uses the filter transform with config.reg sourced from untrusted input, and provides mitigation guidance for callers.
Changes:
- Add a new checklist entry warning about ReDoS risk for
dataset.transformfilterconfig.reg. - Add a dedicated section describing the risk scenario and recommended mitigations (zh/en).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| contents/zh/best-practices/security.md | Adds ReDoS disclosure + mitigations section for dataset filter config.reg (Chinese). |
| contents/en/best-practices/security.md | Adds ReDoS disclosure + mitigations section for dataset filter config.reg (English). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We received a user-reported security finding about a potential ReDoS (Regular Expression Denial of Service) risk in the dataset filter transform when the
regoption is driven by untrusted input.Issue
The filter’s
config.regcompiles user-supplied strings intoRegExpand runs them on every row without checks on pattern complexity or length, which can lead to catastrophic backtracking and DoS (browser tab freeze or SSR blocking).Decision
We are documenting this in the handbook instead of changing runtime behavior: the Security Guidelines (zh & en) now describe the risk and recommend mitigations (e.g. validating or restricting
regwhen config can be untrusted).