Skip to content

[fix](compile) fix gcc compile #60731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hello-stephen wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

[fix](compile) fix gcc compile #60731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions be/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,7 @@ if (COMPILER_GCC)
-Wno-nonnull
-Wno-stringop-overread
-Wno-stringop-overflow
-Wno-array-bounds
-Wno-maybe-uninitialized)
-Wno-array-bounds)
endif ()

if (COMPILER_CLANG)
Expand Down
8 changes: 8 additions & 0 deletions be/src/vec/columns/column_map.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,11 @@ void ColumnMap::update_hash_with_value(size_t n, SipHash& hash) const {
}
}

// Suppress GCC false positive -Wmaybe-uninitialized after inlining XXH3_64bits_withSeed
#if defined(__GNUC__) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#endif
void ColumnMap::update_xxHash_with_value(size_t start, size_t end, uint64_t& hash,
const uint8_t* __restrict null_data) const {
auto& offsets = get_offsets();
Expand Down Expand Up @@ -332,6 +337,9 @@ void ColumnMap::update_xxHash_with_value(size_t start, size_t end, uint64_t& has
}
}
}
#if defined(__GNUC__) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif

void ColumnMap::update_crc_with_value(size_t start, size_t end, uint32_t& hash,
const uint8_t* __restrict null_data) const {
Expand Down
Loading