Skip to content

[fix](compile) fix compile backend on MacOS failed #60723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
924060929 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix](compile) fix compile backend on MacOS failed #60723

924060929 wants to merge 1 commit into from
+12 −0

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Feb 12, 2026

What problem does this PR solve?

fix compile backend on MacOS failed

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 12, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

924060929 commented Feb 12, 2026

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 12, 2026

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.69% (19486/36984)
Line Coverage 36.21% (181525/501266)
Region Coverage 32.56% (140695/432132)
Branch Coverage 33.61% (61041/181613)

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 12, 2026

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.81% (26024/36240)
Line Coverage 54.46% (272315/500029)
Region Coverage 51.97% (226869/436512)
Branch Coverage 53.39% (97334/182317)

freemandealer
freemandealer approved these changes Feb 13, 2026
View reviewed changes
Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@924060929
Copy link
Contributor Author

924060929 commented Feb 13, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Feb 13, 2026

TPC-H: Total hot run time: 28908 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 548175b91d47e2ee55d91e7a9991913d9ed22187, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17628	4444	4273	4273
q2	q3	10652	771	515	515
q4	4675	368	254	254
q5	7572	1189	1012	1012
q6	182	175	150	150
q7	775	848	675	675
q8	9308	1438	1323	1323
q9	4832	4769	4706	4706
q10	6814	1856	1639	1639
q11	472	248	243	243
q12	692	563	469	469
q13	17766	4199	3423	3423
q14	231	220	211	211
q15	937	809	806	806
q16	771	717	657	657
q17	716	848	449	449
q18	5877	5339	5295	5295
q19	1120	979	616	616
q20	507	487	382	382
q21	4526	1940	1552	1552
q22	382	314	258	258
Total cold run time: 96435 ms
Total hot run time: 28908 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4657	4548	4518	4518
q2	q3	1887	2326	1736	1736
q4	852	1197	793	793
q5	4068	4417	4376	4376
q6	199	189	144	144
q7	1774	1745	1554	1554
q8	2494	2692	2610	2610
q9	7498	7469	7325	7325
q10	2730	2799	2365	2365
q11	492	438	417	417
q12	493	597	526	526
q13	4093	4423	3556	3556
q14	291	300	285	285
q15	880	837	810	810
q16	703	752	697	697
q17	1210	1585	1326	1326
q18	7057	6661	6628	6628
q19	968	919	931	919
q20	2126	2190	2034	2034
q21	4029	3558	3369	3369
q22	478	483	396	396
Total cold run time: 48979 ms
Total hot run time: 46384 ms

@doris-robot
Copy link

doris-robot commented Feb 13, 2026

TPC-DS: Total hot run time: 184423 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 548175b91d47e2ee55d91e7a9991913d9ed22187, data reload: false

query5	5045	660	517	517
query6	332	215	216	215
query7	4220	485	265	265
query8	342	253	244	244
query9	8725	2782	2805	2782
query10	520	392	337	337
query11	17240	17673	17257	17257
query12	211	147	130	130
query13	1322	500	396	396
query14	6752	3340	3011	3011
query14_1	3008	2985	2877	2877
query15	231	198	175	175
query16	1163	462	491	462
query17	2246	738	636	636
query18	3026	473	390	390
query19	227	232	201	201
query20	142	131	134	131
query21	335	197	154	154
query22	5264	5543	4872	4872
query23	17283	16831	16629	16629
query23_1	16760	16708	16741	16708
query24	7198	1621	1219	1219
query24_1	1232	1246	1241	1241
query25	557	477	437	437
query26	1249	258	155	155
query27	2731	502	286	286
query28	4421	1904	1898	1898
query29	796	565	465	465
query30	308	247	204	204
query31	862	717	657	657
query32	80	70	69	69
query33	532	336	287	287
query34	915	926	558	558
query35	631	681	604	604
query36	1096	1115	906	906
query37	133	96	85	85
query38	2986	2933	2872	2872
query39	862	864	801	801
query39_1	793	837	932	837
query40	243	151	133	133
query41	65	68	58	58
query42	103	99	103	99
query43	374	385	350	350
query44	
query45	202	187	186	186
query46	890	987	598	598
query47	2080	2125	2034	2034
query48	313	328	239	239
query49	624	468	378	378
query50	687	282	214	214
query51	4125	4215	4147	4147
query52	107	106	99	99
query53	297	334	283	283
query54	287	264	279	264
query55	91	90	86	86
query56	313	316	307	307
query57	1370	1342	1266	1266
query58	292	278	267	267
query59	2565	2703	2539	2539
query60	341	329	313	313
query61	151	143	144	143
query62	634	557	533	533
query63	303	275	282	275
query64	4846	1258	997	997
query65	
query66	1393	442	345	345
query67	16414	16408	16416	16408
query68	
query69	389	310	288	288
query70	1038	982	917	917
query71	337	299	291	291
query72	2759	2623	2357	2357
query73	557	551	323	323
query74	9655	9539	9388	9388
query75	2863	2739	2445	2445
query76	2302	1042	692	692
query77	385	389	309	309
query78	11572	11689	11047	11047
query79	3121	828	593	593
query80	1771	647	554	554
query81	590	288	246	246
query82	1003	147	112	112
query83	340	270	247	247
query84	255	115	100	100
query85	893	500	434	434
query86	540	307	295	295
query87	3133	3083	3002	3002
query88	3631	2689	2681	2681
query89	429	373	340	340
query90	2132	180	172	172
query91	159	153	133	133
query92	87	78	70	70
query93	1938	852	505	505
query94	649	329	301	301
query95	575	329	315	315
query96	644	528	231	231
query97	2452	2521	2384	2384
query98	232	219	223	219
query99	981	997	910	910
Total cold run time: 260130 ms
Total hot run time: 184423 ms

@doris-robot
Copy link

doris-robot commented Feb 13, 2026

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.73% (19500/36984)
Line Coverage 36.25% (181721/501267)
Region Coverage 32.59% (140825/432130)
Branch Coverage 33.65% (61106/181610)

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 13, 2026

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.84% (26036/36240)
Line Coverage 54.49% (272453/500029)
Region Coverage 52.00% (226977/436512)
Branch Coverage 53.42% (97385/182317)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@morrySnow morrySnow morrySnow approved these changes

@zclllyybb zclllyybb Awaiting requested review from zclllyybb zclllyybb is a code owner

@BiteTheDDDDt BiteTheDDDDt Awaiting requested review from BiteTheDDDDt BiteTheDDDDt is a code owner

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

+1 more reviewer

@freemandealer freemandealer freemandealer approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@924060929 @Thearas @hello-stephen @doris-robot @freemandealer @gavinchou @morrySnow