Skip to content

Conversation

@shuke987
Copy link
Collaborator

…pped

What problem does this PR solve?

BinlogConfigCache maintains two internal maps (dbTableBinlogEnableMap and tableTypeMap) that cache BinlogConfig and table type info by db/table ID. These caches are populated lazily when binlog-related operations query a table or database for the first time.

However, when a table or database is dropped, BinlogManager.removeTable() and removeDB() only clean up dbBinlogMap (the binlog data itself) but never call binlogConfigCache.remove() to evict the corresponding cache entries.

Since each newly created table gets a globally incrementing ID, dropped table entries are never overwritten — the cache grows without bound.

Reproduction
Run p0 regression tests in a loop (create tables → run tests → DROP all databases). After 12 rounds:

BinlogConfig instances: 32,213 → 158,744 (+392.8%), strictly increasing every round
dbTableBinlogEnableMap accumulated 105,936 entries (backing array expanded to 262,144 slots, retained ~22MB)
Heap dump reference chain:

Env (serving)
→ BinlogManager
→ BinlogConfigCache
→ dbTableBinlogEnableMap (HashMap, 105,936 entries)

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987
Copy link
Collaborator Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants