[fix](memory) fix ThreadPoolExecutor leak in PublishVersionDaemon #60720
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`publishExecutors` is a static field, but the constructor appends new thread pools on every invocation without checking if they already exist. The constructor is called each time a new Env instance is created, which happens periodically during Env checkpoint/journal replay (the checkpoint thread creates a new Env to replay the journal). Each call appends `publish_thread_pool_num` (default 128) pools to the static list, causing unbounded growth. Heap dump analysis (branch-4.0, 12 rounds of p0 regression) confirmed: - ThreadPoolExecutor: R1: 2,506 → R12: 12,236 (+388.3%), 11/11 strictly increasing - dbExecutors backing array grew to Object[11070] (~86 Env replays × 128 pools) - Each leaked pool retains threads, locks, and condition queues Fix: skip pool creation if publishExecutors is already populated.
shuke987
requested review from
CalvinKirs,
dataroaring and
morningman
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
gavinchou
approved these changes
Feb 12, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
publishExecutors is a static field, but the constructor appends new thread pools on every invocation without checking if they already exist.
The constructor is called each time a new Env instance is created, which happens periodically during Env checkpoint/journal replay (the checkpoint thread creates a new Env to replay the journal). Each call appends publish_thread_pool_num (default 128) pools to the static list, causing unbounded growth.
Heap dump analysis (branch-4.0, 12 rounds of p0 regression) confirmed:
ThreadPoolExecutor: R1: 2,506 → R12: 12,236 (+388.3%), 11/11 strictly increasing
dbExecutors backing array grew to Object[11070] (~86 Env replays × 128 pools)
Each leaked pool retains threads, locks, and condition queues
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)