[Improvement-17843][Master] Add IT case for task timeout alert#18001
[Improvement-17843][Master] Add IT case for task timeout alert#18001shrihari7396 wants to merge 34 commits intoapache:devfrom
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
.../java/org/apache/dolphinscheduler/server/master/integration/cases/WorkflowStartTestCase.java
Outdated
Show resolved
Hide resolved
2361ef0 to
c6f6ed8
Compare
|
Hi @SbloodyS, Thank you for the review. This is my first contribution to this project, so I really appreciate your guidance. Thanks! |
|
Hi @SbloodyS, The milestone-label-check is currently failing because no milestone and valid label are assigned to this PR. Could you please help assign the appropriate milestone and label so the check can pass? Thank you! |
Milestones are required before the merger, and contributors do not need to pay attention to them. You should check failed IT. It did not passed. |
|
Hi @SbloodyS, I would like to work on adding the integration test case for task timeout alert in the master module. While preparing the environment, my IDE formatter modified some files unintentionally. I will revert any unrelated formatting changes and ensure only the relevant test case changes are included in the PR. I will first analyze the current timeout handling and alert triggering flow to ensure the IT covers the correct execution path (timeout detection → task state update → alert creation). Please let me know if there are any specific scenarios or timeout strategies (e.g., WARN vs FAILED) that you would like the test to cover. Thanks! |
|
Hi @SbloodyS, I have applied spotless formatting and updated the PR accordingly. Thanks. |
shrihari7396
left a comment
There was a problem hiding this comment.
Thanks for the review. I have reverted the unnecessary changes and updated the PR accordingly.
I also ensured the formatting issues are fixed.
Please let me know if any further modifications are needed.
.../java/org/apache/dolphinscheduler/server/master/integration/cases/WorkflowStartTestCase.java
Outdated
Show resolved
Hide resolved
|
Hi @SbloodyS, Just a gentle follow-up on this PR. I have addressed the requested changes. Could you please take another look when you get time? Thank you! |
ruanwenjun
left a comment
There was a problem hiding this comment.
You should do assertion of the alert event in DB.
|
Hi @ruanwenjun, I have updated the PR based on the previous feedback. Could you please review it and let me know if the changes meet your expectations? |
|
|
Thank you for the clarification. I understand the concern now. I will update the PR accordingly. |
|
Hi @ruanwenjun, I have updated the PR. Please check it and let me know if it meets your requirements. Also, let me know if any further changes are needed. |
|
Thanks for the clarification. I have restored the PR template and updated the PR description. Please let me know if any further changes are required. |
.../java/org/apache/dolphinscheduler/server/master/integration/cases/WorkflowStartTestCase.java
Outdated
Show resolved
Hide resolved
|
Hi @ruanwenjun, |
|
Hi @ruanwenjun, @SbloodyS, Just a gentle follow-up on this PR. Please let me know if any further changes are needed from my side. Thank you! |
|
Hi @ruanwenjun @SbloodyS , |
|
Hi @ruanwenjun @SbloodyS, Just a gentle follow-up regarding the milestone label check. Since all CI tests are passing on my side, could you please confirm if a milestone needs to be added or if anything else is required from me? Thank you! |
|
Hi @ruanwenjun @SbloodyS, Gentle ping on this PR. Could you please review when you have time? Please let me know if any further changes are needed from my side. Thanks! |
|
|
Hi @ruanwenjun @SbloodyS, I’ve addressed the requested changes and updated the PR. Thanks! |



Purpose of the pull request
Closes #17843
This pull request adds integration test (IT) cases for verifying task timeout alert behavior during workflow execution in the master module.
Brief change log
Added two integration test cases:
testStartWorkflow_withTimeoutWarnTasktestStartWorkflow_withTimeoutWarnFailedTaskAdded YAML workflow definitions for timeout scenarios.
Added repository method to query alerts from the database.
Verified that timeout alerts are generated and persisted correctly.
Verify this pull request
The changes can be verified by running the added integration tests:
WorkflowStartTestCase#testStartWorkflow_withTimeoutWarnTaskWorkflowStartTestCase#testStartWorkflow_withTimeoutWarnFailedTaskThese tests:
Pull Request Notice
No incompatible changes were introduced.