[fix] Remove tenant arg in workflow definition#13212
Merged
zhongjiajie merged 1 commit intoapache:devfrom Dec 19, 2022
Merged
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## dev #13212 +/- ##
============================================
- Coverage 39.41% 39.39% -0.03%
+ Complexity 4316 4315 -1
============================================
Files 1077 1077
Lines 40814 40818 +4
Branches 4683 4680 -3
============================================
- Hits 16086 16079 -7
- Misses 22934 22946 +12
+ Partials 1794 1793 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhongjiajie
force-pushed
the
i-py-rm-tenant-simple
branch
from
b27b715 to
dea0f84
Compare
current tenant in workflow only work when the first time user do not exist, when user change the tenant in workflow but tenant exist, it will be ignore, so we try to remove it from workflow, and in apache#40 we try to create both user and tenant vis cli instead of auto create
zhongjiajie
force-pushed
the
i-py-rm-tenant-simple
branch
from
dea0f84 to
2f25ecb
Compare
|
SonarCloud Quality Gate failed. |
jieguangzhou
approved these changes
Dec 19, 2022
zhongjiajie
added a commit
that referenced
this pull request
Mar 23, 2023
current tenant in workflow only work when the first time user do not exist, when user change the tenant in workflow but tenant exist, it will be ignore, so we try to remove it from workflow, and in #40 we try to create both user and tenant vis cli instead of auto create
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current tenant in workflow only work when the first time user do not exist, when user change the tenant in workflow but tenant exist, it will be ignore, so we try to remove it from workflow, and in apache/dolphinscheduler-sdk-python#40 we try to create both user and tenant vis cli instead of auto create