Optimize ByteViewGroupValueBuilder vectorized_append#21579
Closed
Dandandan wants to merge 1 commit intoapache:mainfrom
Closed
Optimize ByteViewGroupValueBuilder vectorized_append#21579Dandandan wants to merge 1 commit intoapache:mainfrom
Dandandan wants to merge 1 commit intoapache:mainfrom
Conversation
- Reuse input views directly instead of reconstructing via make_view: for inline values (len <= 12), copy the view as-is; for non-inline values, update buffer_index/offset using ByteView's builder API - Switch Nulls::None and Nulls::Some branches from for loops to extend - Use doubling allocation strategy for in_progress buffer (2MB initial, up to 32MB max) to reduce buffer flush frequency - Extract shared copy_view helper for single-row append_val_inner - Remove now-unused do_append_val_inner, ensure_in_progress_big_enough, and make_view import Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-byteview-append-v2 (b518942) to 16e578d (merge-base) diff using: tpcds File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-byteview-append-v2 (b518942) to 16e578d (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing optimize-byteview-append-v2 (b518942) to 16e578d (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A - Performance optimization
Rationale for this change
The
vectorized_append_innermethod inByteViewGroupValueBuilderwas usingmake_viewto reconstruct views from scratch (re-reading value bytes to build the prefix) and copying non-inline data one row at a time in aforloop. Both are unnecessary since the input array already has correctly formed views.What changes are included in this PR?
make_view. For inline values (len ≤ 12), the view is copied as-is. For non-inline values, the view's length and prefix are preserved, only updatingbuffer_index/offsetviaByteView's builder API.extendinstead offorloops for bothNulls::NoneandNulls::Somebranches.in_progressbuffer: starts at 2MB, doubles on each flush up to 32MB max. Reduces buffer flush frequency for large workloads.copy_viewhelper used by bothappend_val_innerandvectorized_append_inner.do_append_val_inner,ensure_in_progress_big_enough, andmake_viewimport.Benchmark results
Are these changes tested?
Existing tests cover the functionality (6/6 pass). Verified with
cargo check,cargo clippy, andcargo test.Are there any user-facing changes?
No - internal performance optimization only.
🤖 Generated with Claude Code