fix(spark): add custom nullability to SparkMakeInterval#21564
Open
HueCodes wants to merge 1 commit intoapache:mainfrom
Open
fix(spark): add custom nullability to SparkMakeInterval#21564HueCodes wants to merge 1 commit intoapache:mainfrom
HueCodes wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
make_intervalneed to have custom nullability #19155.Rationale for this change
SparkMakeInterval uses the default is_nullable which always returns true. Spark derives nullability from inputs: nullable only if any input is nullable or seconds contains non-finite values.
What changes are included in this PR?
Add return_field_from_args() matching the pattern in SparkMakeDtInterval.
Are these changes tested?
Yes, added return_field_respects_nullability test.
Are there any user-facing changes?
No.