-
Notifications
You must be signed in to change notification settings - Fork 1.9k
perf: Optimize translate() UDF for scalar inputs #20305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
neilconway
wants to merge
5
commits into
apache:main
Choose a base branch
from
neilconway:neilc/optimize-translate-scalars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
perf: Optimize translate() UDF for scalar inputs #20305
neilconway
wants to merge
5
commits into
apache:main
from
neilconway:neilc/optimize-translate-scalars
+220
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIK there is no reason not to support this.
When the second and third arguments are constants (which is common), we can build the lookup table once, rather than rebuilding it for every input row. When all of the arguments are ASCII-only, we can do lookups via a fixed-size lookup table that directly maps ASCII byte values, rather than a hash table.
Contributor
Author
|
Benchmark results below. There is a very small regression for array (non-constant) inputs. That's a bit surprising to me -- I'd suspect for non-microbenchmark scenarios, the performance difference shouldn't be measurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
functions
Changes to functions implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
translate()is commonly invoked with constant values for its second and third arguments. We can take advantage of that to significantly optimize its performance by precomputing the translation lookup table, rather than recomputing it for every row. For scalar ASCII inputs, this yields roughly a 10x performance improvement. For scalar UTF8 inputs, the performance improvement is more like 50%, although less so for long strings.What changes are included in this PR?
Are these changes tested?
Yes. Added an extra test case and did a bunch of benchmarking.
Are there any user-facing changes?
No.