chore: Remove "extern crate criterion" in benches #20299
+25
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
neilconway
force-pushed
the
neilc/rm-external-crate
branch
from
e2c13f7 to
afd861a
Compare
This is no longer necessary with modern editions of Rust. In many cases, we also did `#[macro_use]`, so removing this cleans up the namespace of the file doing the `use`. Along the way, remove a few unnecessary `extern crate arrow` and similar from the benchmark code.
neilconway
force-pushed
the
neilc/rm-external-crate
branch
from
afd861a to
ffb7fbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is no longer necessary with modern editions of Rust. In many cases, we also did
#[macro_use], so removing this cleans up the namespace of the file doing theuse.What changes are included in this PR?
Remove "extern crate criterion" in benchmark code, and update "use" statements as necessary. Along the way, remove a few unnecessary
extern crate arrowand similar from the benchmark code.Are these changes tested?
Yes, but no new tests added or needed.
Are there any user-facing changes?
No.