Improve hash join exec builder #20276
Open
+188
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
Prior the patch HashJoinExecBuilder constructed from an existing node reseted some fields of the node, e.g. dynamic filters, metrics. It significantly reduces usage scope of the builder. This patch improves the implementation. Now builder created from the existing node preserves all fields in case they have not been explicitly updated. Also builder now tracks flag if it must recompute plan properties. Closes apache#20270
askalt
force-pushed
the
askalt/improve-hash-join-exec-builder
branch
from
fbc498f to
dcc9cfa
Compare
jonathanc-n
reviewed
Feb 12, 2026
Contributor
jonathanc-n
left a comment
jonathanc-n
left a comment
There was a problem hiding this comment.
I left a comment, but this is a nicely designed. Thanks!
| } | ||
|
|
||
| /// Helps to build [`HashJoinExec`]. | ||
| /// |
Contributor
There was a problem hiding this comment.
We are refactoring this to make it easier for the person who is going to use it throughout the codebase and make better decisions like adding new fields.
I think the documentation should be geared more to how someone should add a new field. So explicitly adding something like, "if a field is changed + it is used to compute properties, preserve_properties should be set to false during reassignment"
jonathanc-n
reviewed
Feb 12, 2026
| } | ||
|
|
||
| /// Reset node state. | ||
| pub fn reset_state(mut self) -> Self { |
Contributor
There was a problem hiding this comment.
I think it should be mentioned in the HashExecBuilder docs that this is used to reset runtime features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #20270
Prior the patch HashJoinExecBuilder constructed from an existing node reseted some fields of the node, e.g. dynamic filters, metrics. It significantly reduces usage scope of the builder.
What changes are included in this PR?
This patch improves the implementation. Now builder created from the existing node preserves all fields in case they have not been explicitly updated. Also builder now tracks flag if it must recompute plan properties.