Add xml '...' TypedString support for PostgreSQL#2299
Merged
yoavcloud merged 5 commits intoapache:mainfrom Apr 10, 2026
Merged
Conversation
yoavcloud
approved these changes
Apr 10, 2026
Contributor
|
Looks good, @LucaCappelletti94! |
Contributor
Author
|
Will proceed to step 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR in a chain adding PostgreSQL XML function support (split from #2252).
<foo/>typed string support for PostgreSQL and Generic dialects, parsing it asExpr::TypedString(same mechanism used by DATE '...', TIME '...', etc.)supports_xml_expressions()dialect method (default false, true for PostgreSQL and Generic) per reviewer feedback to avoiddialect_of!is_simple_unquoted_object_namehelper for matching single unquoted identifiers inDataType::Custom