fix: [iceberg] Keep deep copy for Iceberg Java integration scan path #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CometScanWrapper unconditionally set isFfiSafe=true, which told native ScanExec to skip deep copies for all scans. This is correct for CometScanExec (native_iceberg_compat) which now uses immutable Arrow readers, but incorrect for CometBatchScanExec (Iceberg Java integration via SupportsComet) which still uses mutable buffers. Make isFfiSafe conditional on the scan type: true for CometScanExec, false for CometBatchScanExec. Also remove the stale hasScanUsingMutableBuffers check for CometScanExec since PR apache#3411 replaced mutable buffers with immutable Arrow readers. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CometSink.isFfiSafetake the operator as a parameter so FFI safety can be determined per-scanCometScanWrapper.isFfiSafenow returnstrueonly forCometScanExec(native_iceberg_compat, which uses immutable Arrow readers after perf: Remove mutable buffers from scan partition/missing columns #3411), andfalseforCometBatchScanExec(Iceberg Java integration via SupportsComet, which still uses mutable buffers)hasScanUsingMutableBufferscheck forCometScanExecsince perf: Remove mutable buffers from scan partition/missing columns #3411 replaced mutable buffers withArrowConstantColumnReaderTest plan
[iceberg]in title)🤖 Generated with Claude Code