Adjust misformatted logs

[winterhazel]

Description

Fixes some misformatted logs in the deployment & Quota balance calculation processes.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

Before:

2024-11-05 12:40:32,643 INFO  [cloudstack.quota.QuotaManagerImpl_EnhancerByCloudStack_281d8029] (Usage-Job-1:[]) (logid:) Processing quota balance for account[{}] between [{}] and [{}].

After:

2024-11-05 12:40:38,903 INFO  [cloudstack.quota.QuotaManagerImpl_EnhancerByCloudStack_281d8029] (Usage-Job-1:[]) (logid:) Processing quota balance for account [{"accountName":"system","domainId":1,"id":1,"uuid":"60b8ca5a-28b2-11ef-a04e-6ac09c2b3d6b"}] between [2024-11-05T00:13:00.000+0000] and [2024-11-05T12:39:59.000+0000].

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.80%. Comparing base (8af08dd) to head (902dc74).
Report is 40 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../org/apache/cloudstack/quota/QuotaManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20    #9889      +/-   ##
============================================
- Coverage     15.81%   15.80%   -0.01%     
- Complexity    12580    12586       +6     
============================================
  Files          5627     5627              
  Lines        492260   492343      +83     
  Branches      63955    59694    -4261     
============================================
- Hits          77832    77826       -6     
- Misses       405905   405993      +88     
- Partials       8523     8524       +1     

Flag	Coverage Δ
uitests	4.04% <ø> (-0.01%)	⬇️
unittests	16.62% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11506

[DaanHoogland]

compiles, ship it ;)

But seriously, I am not sure if this is covered by any tests...

[bernardodemarco]

LGTM

[JoaoJandre]

@blueorangutan package

[JoaoJandre]

compiles, ship it ;)

But seriously, I am not sure if this is covered by any tests...

@DaanHoogland I think that for a change like this there isn't much to test. The CI should suffice, no?

[DaanHoogland]

compiles, ship it ;)
But seriously, I am not sure if this is covered by any tests...

@DaanHoogland I think that for a change like this there isn't much to test. The CI should suffice, no?

You are absolutely right @JoaoJandre, and looking back at the code I am not sure if we need even that.