fix: remove double <form> element from 2FA form

[phsm]

Description

This PR fixes the password managers autofill functionality in the 2FA OTP code form.
It is caused by double <form> element.

Fixes: #9510

The PR simply removes the outer empty <form> element, leaving the inner one intact.

Steps to reproduce:

1. Install 1password password manager and the browser extension.
2. Enable 2FA authentication for your Cloudstack user.
3. Save the OTP token for your user in 1password so it now provides OTP passwords.
4. Try to login to Cloudstack UI with 1password autofill.

Expected behavior:
1password fills all 6 numbers of the OTP token into the input form.

Actual behavior:
1password only fills 3 numbers out of 6 into the input form.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Before:

2fa_current.mp4

After:

2fa_fixed.mp4

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build failed: ✖️
(SL-JID-467)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.78%. Comparing base (019f2c6) to head (a7ff7bf).
Report is 50 commits behind head on 4.20.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20    #9851      +/-   ##
============================================
- Coverage     15.78%   15.78%   -0.01%     
- Complexity    12564    12565       +1     
============================================
  Files          5627     5627              
  Lines        492250   492250              
  Branches      61405    63543    +2138     
============================================
- Hits          77710    77708       -2     
- Misses       406066   406067       +1     
- Partials       8474     8475       +1     

Flag	Coverage Δ
uitests	4.04% <ø> (ø)
unittests	16.60% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build failed: ✖️
(SL-JID-468)

[DaanHoogland]

clgtm, I cannot see a functional difference in your video snippets (before/after) @phsm?

[phsm]

clgtm, I cannot see a functional difference in your video snippets (before/after) @phsm?

Thanks for pointing that out. I indeed made it unclear.

Replaced the first video.

[phsm]

Hello,
is there any progress with this PR?

[DaanHoogland]

Hello, is there any progress with this PR?

@phsm , the rule is two reviews of which at least one has done testing. So far I am the only one that has reviewed. You could ask any active committer to review as well. A good trick is usually to look at the git blame output to find someone with experience/knowledge of the involved code. Just keep in mind that some may not be active anymore.

[DaanHoogland]

@blueorangutan ui

[phsm]

@rohityadavcloud I see you have made changes to this file in the past. Perhaps you can take a look?

[DaanHoogland]

@blueorangutan ui