Add cpu speed detection methods#9762
Conversation
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #9762 +/- ##
==========================================
Coverage 15.78% 15.78%
- Complexity 12564 12565 +1
==========================================
Files 5627 5627
Lines 492250 492261 +11
Branches 61405 62190 +785
==========================================
+ Hits 77710 77718 +8
- Misses 406066 406070 +4
+ Partials 8474 8473 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11266 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-11619)
|
BryanMLima
left a comment
There was a problem hiding this comment.
@DaanHoogland @BartJM looks like some unwanted commits were added to this PR, probably due to the force push in the main. @DaanHoogland, could you take a look on this?
@BartJM , you want to execute and force push ( |
Added additional match for lscpu Added additional file to check
0ceff7f to
78a981f
Compare
BryanMLima
left a comment
There was a problem hiding this comment.
CLGTM, I did not manually test it.
|
@blueorangutan test ubuntu24 kvm-ubuntu24 |
|
[SF] Trillian test result (tid-11801)
|
|
@kiranchavala can you check thsi and see if this fixes #9819 |
Sure @DaanHoogland I will take a look |
|
@BartJM could you rebase this to 4.20. So that we could have this in the 4.20.1 release. Thanks. |
|
@blueorangutan package |
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12469 |
|
@blueorangutan test |
|
@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-12468)
|
@Pearl1594 , cc @kiranchavala , these errors seem consistent on 4.20, lately. Can we merge this? |
@DaanHoogland I have seen these exact failures in other PRs. I think we are safe to merge here. |
Added additional match for lscpu Added additional file to check
Description
This PR ads two additional methods to detect cpu speed on kvm hosts. This will improve the speed detection on AMD Epyc cpu's. For cpu's where the Ghz is in the model name no change will occur. For other cpu's the detected cpu speed ca change to the max Mhz of the cpu.
CPU max MHzvalue from lscpuscaling_max_freqFixes: #6914
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
Tested on a kvm host with an AMD EPYC 7601 cpu.
On an kvm centos8 vm without the lscpu matches and neither file the agent still falls back on host capabilities.