Routed mode: minor improvements and fixes by weizhouapache · Pull Request #9697 · apache/cloudstack

weizhouapache · 2024-09-18T07:07:37Z

Description

This PR

adds a global setting to enable/disable the Static/Dynamic routing feature
add some unit tests
fixes the issue that frr.conf has no settings when VR is restarted.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2024-09-18T07:08:16Z

@blueorangutan package

blueorangutan · 2024-09-18T07:10:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-09-18T07:15:06Z

Codecov Report

Attention: Patch coverage is 63.10680% with 38 lines in your changes missing coverage. Please review.

Project coverage is 15.95%. Comparing base (f7b7339) to head (53b61cd).
Report is 21 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java	14.28%	9 Missing and 3 partials ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java	0.00%	8 Missing ⚠️
...g/apache/cloudstack/api/response/ZoneResponse.java	0.00%	7 Missing ⚠️
...ache/cloudstack/network/RoutedIpv4ManagerImpl.java	86.11%	4 Missing and 1 partial ⚠️
...er/src/main/java/com/cloud/bgp/BGPServiceImpl.java	88.88%	2 Missing and 1 partial ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java	71.42%	1 Missing and 1 partial ⚠️
...com/cloud/api/query/dao/DataCenterJoinDaoImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20    #9697      +/-   ##
============================================
+ Coverage     15.80%   15.95%   +0.15%     
- Complexity    12586    12735     +149     
============================================
  Files          5627     5627              
  Lines        492294   492503     +209     
  Branches      62198    59738    -2460     
============================================
+ Hits          77824    78596     +772     
+ Misses       405946   405234     -712     
- Partials       8524     8673     +149

Flag	Coverage Δ
uitests	`4.03% <ø> (-0.02%)`	⬇️
unittests	`16.79% <63.10%> (+0.16%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-09-18T08:10:15Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11137

blueorangutan · 2024-09-18T21:52:33Z

[SF] Trillian Build Failed (tid-11515)

blueorangutan · 2024-09-19T12:59:20Z

[SF] Trillian test result (tid-11516)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51439 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9697-t11516-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…ovement

sureshanaparti

clgtm

…ovement

…outed is disabled

…p peer/ASN range/network/vpc

blueorangutan · 2024-11-13T13:21:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11560

weizhouapache · 2024-11-27T19:49:09Z

@blueorangutan package

weizhouapache · 2024-11-27T19:54:38Z

@blueorangutan package

blueorangutan · 2024-11-27T19:56:06Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-27T20:50:18Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11618

weizhouapache · 2024-11-28T08:04:21Z

@blueorangutan package

blueorangutan · 2024-11-28T08:06:06Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-28T09:02:40Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11624

blueorangutan · 2024-11-28T10:17:47Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11631

blueorangutan · 2024-11-28T12:57:26Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11634

weizhouapache · 2024-11-28T13:03:01Z

@blueorangutan test

blueorangutan · 2024-11-28T13:04:06Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-11-28T14:07:31Z

[SF] Trillian Build Failed (tid-11810)

weizhouapache · 2024-11-29T08:10:05Z

@blueorangutan package

blueorangutan · 2024-11-29T08:12:07Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-29T10:05:20Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11652

weizhouapache · 2024-11-29T10:21:46Z

@blueorangutan package

blueorangutan · 2024-11-29T10:24:09Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-29T11:40:37Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11656

weizhouapache · 2024-11-29T11:45:21Z

@blueorangutan test

blueorangutan · 2024-11-29T11:46:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-11-30T03:29:47Z

[SF] Trillian test result (tid-11824)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54107 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9697-t11824-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

* Routed: add global setting to enable/disable routed mode * Routed: add unit tests * Routed: add unit tests RoutedIpv4ManagerImplTest * PR9697: fix end of files lint error * PR9697: fix unit tests error with JDK17 * Routed: do not show ROUTED mode when create network/vpc offering if routed is disabled * Routed: check if routed network is enabled when create ipv4 subnet/bgp peer/ASN range/network/vpc * Routed: UI bug fix and improvements * Routed: apply available BGP peers when VR is restarted

boring-cyborg bot added component:api component:management-server component:networking component:UI component:vpc labels Sep 18, 2024

weizhouapache added this to the 4.20.1.0 milestone Sep 18, 2024

weizhouapache added 4 commits September 18, 2024 10:09

Routed: add global setting to enable/disable routed mode

c1bd1e1

Routed: add unit tests

ae67d19

Routed: add unit tests RoutedIpv4ManagerImplTest

c71bae5

PR9697: fix end of files lint error

cea6511

weizhouapache force-pushed the 4.20-routed-mode-improvement branch from 51c97e4 to decc016 Compare September 18, 2024 08:10

weizhouapache force-pushed the 4.20-routed-mode-improvement branch from decc016 to 889eca5 Compare September 18, 2024 09:40

PR9697: fix unit tests error with JDK17

3b56f10

weizhouapache force-pushed the 4.20-routed-mode-improvement branch from 889eca5 to 3b56f10 Compare September 18, 2024 11:23

weizhouapache marked this pull request as ready for review September 19, 2024 06:34

Merge remote-tracking branch 'apache/main' into 4.20-routed-mode-impr…

b5360ae

…ovement

sureshanaparti approved these changes Sep 20, 2024

View reviewed changes

DaanHoogland added the status:ready-for-merge label Sep 20, 2024

kiranchavala self-assigned this Sep 26, 2024

weizhouapache added 3 commits September 27, 2024 09:01

Merge remote-tracking branch 'apache/main' into 4.20-routed-mode-impr…

0753d6d

…ovement

Routed: do not show ROUTED mode when create network/vpc offering if r…

0f4d801

…outed is disabled

Routed: check if routed network is enabled when create ipv4 subnet/bg…

2772157

…p peer/ASN range/network/vpc

DaanHoogland added status:needs-testing and removed status:ready-for-merge labels Sep 27, 2024

weizhouapache closed this Nov 27, 2024

weizhouapache reopened this Nov 27, 2024

weizhouapache changed the base branch from main to 4.20 November 27, 2024 19:54

weizhouapache merged commit 22a6604 into apache:4.20 Nov 30, 2024

DaanHoogland deleted the 4.20-routed-mode-improvement branch November 30, 2024 21:12

Pearl1594 added this to ACS 4.20.1 Mar 17, 2025

Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025

Conversation

weizhouapache commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Sep 18, 2024

Uh oh!

blueorangutan commented Sep 18, 2024

Uh oh!

codecov bot commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Sep 18, 2024

Uh oh!

blueorangutan commented Sep 18, 2024

Uh oh!

blueorangutan commented Sep 19, 2024

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Nov 13, 2024

Uh oh!

weizhouapache commented Nov 27, 2024

Uh oh!

weizhouapache commented Nov 27, 2024

Uh oh!

blueorangutan commented Nov 27, 2024

Uh oh!

blueorangutan commented Nov 27, 2024

Uh oh!

weizhouapache commented Nov 28, 2024

Uh oh!

blueorangutan commented Nov 28, 2024

Uh oh!

blueorangutan commented Nov 28, 2024

Uh oh!

blueorangutan commented Nov 28, 2024

Uh oh!

blueorangutan commented Nov 28, 2024

Uh oh!

weizhouapache commented Nov 28, 2024

Uh oh!

blueorangutan commented Nov 28, 2024

Uh oh!

blueorangutan commented Nov 28, 2024

Uh oh!

weizhouapache commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

weizhouapache commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

weizhouapache commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 29, 2024

Uh oh!

blueorangutan commented Nov 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

weizhouapache commented Sep 18, 2024 •

edited

Loading

codecov bot commented Sep 18, 2024 •

edited

Loading