utils: add wrapper for the loading cache by shwstppr · Pull Request #9638 · apache/cloudstack

shwstppr · 2024-09-05T05:28:24Z

Description

Follow up for #9628
Creates a utility class LazyCache which currently wraps Caffeine library Cache class.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr · 2024-09-05T05:31:09Z

@blueorangutan package

blueorangutan · 2024-09-05T05:32:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Follow up for apache#9638 Creates a utility class LazyCache which currently wraps Caffeine library Cache class. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Follow up for apache#9628 Creates a utility class LazyCache which currently wraps Caffeine library Cache class. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

codecov · 2024-09-05T05:40:49Z

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.58%. Comparing base (2245d98) to head (e6f1090).
Report is 164 commits behind head on main.

Files with missing lines	Patch %	Lines
...a/org/apache/cloudstack/utils/cache/LazyCache.java	93.75%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #9638     +/-   ##
===========================================
  Coverage     15.57%   15.58%             
- Complexity    12056    12060      +4     
===========================================
  Files          5506     5507      +1     
  Lines        482919   482932     +13     
  Branches      61184    62859   +1675     
===========================================
+ Hits          75233    75245     +12     
  Misses       399375   399375             
- Partials       8311     8312      +1

Flag	Coverage Δ
uitests	`4.17% <ø> (ø)`
unittests	`16.36% <94.44%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-09-05T06:45:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10982

yadvr · 2024-09-05T06:53:45Z

utils/src/main/java/org/apache/cloudstack/utils/cache/LazyCache.java

+import com.github.benmanes.caffeine.cache.Caffeine;
+import com.github.benmanes.caffeine.cache.LoadingCache;
+
+public class LazyCache<K, V> {


minor nit - CacheUtils ?

intentionally didn't use *Utils as we are/will be creating objects of this class unlike other static Utils classes. Any other suggestions maybe?

How about org.apache.cloudstack.utils.Cache, @shwstppr ?

DaanHoogland

clgtm

yadvr · 2024-09-05T17:23:35Z

@blueorangutan test

blueorangutan · 2024-09-05T17:24:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

yadvr · 2024-09-12T07:01:11Z

@DaanHoogland @JoaoJandre do we need manual testing or is the smoketests good enough? Looks like just refactoring to me.

@blueorangutan test

blueorangutan · 2024-09-12T07:02:04Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-09-12T21:56:39Z

[SF] Trillian test result (tid-11458)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51399 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9638-t11458-kvm-ol8.zip
Smoke tests completed. 138 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	400.00	test_vm_life_cycle.py

JoaoJandre · 2024-09-17T12:03:43Z

@shwstppr @rohityadavcloud why is this needed for 4.20? It seems like it could go in 4.20.1

shwstppr · 2024-09-18T04:42:33Z

@JoaoJandre It is just refactoring and good to have. I'm okay if you want to move it to 4.20.1.

shwstppr · 2024-12-04T07:25:54Z

Closing this as it is part of #9840

shwstppr force-pushed the add-cache-wrapper branch from 713b2a2 to 302d79d Compare September 5, 2024 05:29

shwstppr force-pushed the add-cache-wrapper branch from 302d79d to 3842f13 Compare September 5, 2024 05:32

utils: add wrapper for the loading cache

e6f1090

Follow up for apache#9628 Creates a utility class LazyCache which currently wraps Caffeine library Cache class. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr force-pushed the add-cache-wrapper branch from 3842f13 to e6f1090 Compare September 5, 2024 05:33

yadvr reviewed Sep 5, 2024

View reviewed changes

yadvr approved these changes Sep 5, 2024

View reviewed changes

yadvr added this to the 4.20.0.0 milestone Sep 5, 2024

yadvr requested a review from DaanHoogland September 5, 2024 06:54

DaanHoogland approved these changes Sep 5, 2024

View reviewed changes

DaanHoogland added the status:needs-testing label Sep 5, 2024

shwstppr marked this pull request as ready for review September 6, 2024 11:16

JoaoJandre modified the milestones: 4.20.0.0, 4.21.0.0 Sep 10, 2024

yadvr modified the milestones: 4.21.0.0, 4.20.1.0 Sep 12, 2024

sureshanaparti approved these changes Sep 12, 2024

View reviewed changes

DaanHoogland removed the status:needs-testing label Sep 16, 2024

yadvr modified the milestones: 4.20.1.0, 4.20.0.0 Sep 17, 2024

apache deleted a comment from blueorangutan Sep 17, 2024

yadvr requested a review from JoaoJandre September 17, 2024 10:12

JoaoJandre modified the milestones: 4.20.0.0, 4.20.1.0 Sep 18, 2024

shwstppr closed this Dec 4, 2024

DaanHoogland deleted the add-cache-wrapper branch December 4, 2024 07:29

Conversation

shwstppr commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

shwstppr commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

codecov bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

yadvr Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

shwstppr Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

yadvr commented Sep 12, 2024

Uh oh!

blueorangutan commented Sep 12, 2024

Uh oh!

blueorangutan commented Sep 12, 2024

Uh oh!

JoaoJandre commented Sep 17, 2024

Uh oh!

shwstppr commented Sep 18, 2024

Uh oh!

shwstppr commented Dec 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shwstppr commented Sep 5, 2024 •

edited

Loading

codecov bot commented Sep 5, 2024 •

edited

Loading