UI: update ip ranges of shared networks#7896
Merged
yadvr merged 2 commits intoapache:4.18from Aug 23, 2023
Merged
Conversation
Member
Author
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Aug 23, 2023
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, tested in qa
Member
Author
thanks @DaanHoogland @rohityadavcloud can you review ? |
Codecov Report
@@ Coverage Diff @@
## 4.18 #7896 +/- ##
=========================================
Coverage 13.06% 13.06%
Complexity 9083 9083
=========================================
Files 2720 2720
Lines 257289 257289
Branches 40116 40116
=========================================
Hits 33610 33610
Misses 219458 219458
Partials 4221 4221 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yadvr
approved these changes
Aug 23, 2023
Member
yadvr
left a comment
yadvr
left a comment
There was a problem hiding this comment.
LGTM thanks @weizhouapache I can quick test and report findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7825
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?