Merged
Conversation
DaanHoogland
approved these changes
Aug 22, 2023
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
looks good and from experience this is the difference. currently not working on a mac, so test from user needed.
weizhouapache
approved these changes
Aug 22, 2023
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
needs a manual testing
yadvr
approved these changes
Aug 22, 2023
Member
|
@rohityadavcloud |
yadvr
reviewed
Aug 22, 2023
| # For macOS, use two parameters, if gnu sed is not set up | ||
| Darwin*) | ||
| if ! $(which sed | grep -q gnu); then | ||
| sedi='-i ""' |
Member
There was a problem hiding this comment.
LGTM. Gnu sed is installable via brew install gnu-sed which installs it on
PATH="/opt/homebrew/opt/gnu-sed/libexec/gnubin:$PATH"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR keeps the same
sedflags as Linux build hosts, if the end user has installed GNU sed rather than the one shipping with MacOS.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested locally