Skip to content

UI: Fix hide delete button for templates that are in Installing template state#7882

Merged
yadvr merged 2 commits intoapache:4.18from
shapeblue:ui-hide-templates-installing-state
Aug 22, 2023
Merged

UI: Fix hide delete button for templates that are in Installing template state#7882
yadvr merged 2 commits intoapache:4.18from
shapeblue:ui-hide-templates-installing-state

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

Description

This PR hides the Delete Template button when a template is installing

Fixes: #7865

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 20, 2023

Codecov Report

Merging #7882 (b6cacb2) into 4.18 (f7345e8) will increase coverage by 0.00%.
Report is 1 commits behind head on 4.18.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7882   +/-   ##
=========================================
  Coverage     13.04%   13.04%           
- Complexity     9067     9069    +2     
=========================================
  Files          2720     2720           
  Lines        257236   257236           
  Branches      40103    40103           
=========================================
+ Hits          33552    33556    +4     
+ Misses       219474   219470    -4     
  Partials       4210     4210           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nvazquez
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but i think can be more legible.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7882 (QA-JID-152)

@nvazquez
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7882 (QA-JID-154)

@weizhouapache
Copy link
Copy Markdown
Member

@nvazquez @andrijapanicsb @DaanHoogland
we could hide the button for the templates which is downloading as well.

however, what if the template is stuck at downloading or installing ?

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 22, 2023

It doens't allow deletion until it times out or errors. LGTM, merging this.

@yadvr yadvr merged commit 405ef82 into apache:4.18 Aug 22, 2023
@yadvr yadvr deleted the ui-hide-templates-installing-state branch August 22, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide delete button for templates that are in "Installing template" state

5 participants