Skip to content

UI: Show iso urls#7869

Merged
weizhouapache merged 2 commits intoapache:4.18from
DaanHoogland:showIsoUrls
Aug 15, 2023
Merged

UI: Show iso urls#7869
weizhouapache merged 2 commits intoapache:4.18from
DaanHoogland:showIsoUrls

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

Description

This PR shows the url in the iso details...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@DaanHoogland DaanHoogland added this to the 4.18.1.0 milestone Aug 15, 2023
@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@weizhouapache
Copy link
Copy Markdown
Member

It looks the java changes have no impact, right ? @DaanHoogland

@weizhouapache weizhouapache changed the title Show iso urls UI: Show iso urls Aug 15, 2023
@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7869 (QA-JID-143)

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

It looks the java changes have no impact, right ? @DaanHoogland

no, that's right. just cleaning of the source

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Copy Markdown
Member

verified on QA server (both admin and user)

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2023

Codecov Report

Merging #7869 (b6ad47a) into 4.18 (a47a4f4) will decrease coverage by 0.01%.
Report is 1 commits behind head on 4.18.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.18    #7869      +/-   ##
============================================
- Coverage     13.02%   13.02%   -0.01%     
+ Complexity     9040     9039       -1     
============================================
  Files          2720     2720              
  Lines        257094   257094              
  Branches      40092    40092              
============================================
- Hits          33491    33489       -2     
- Misses       219398   219401       +3     
+ Partials       4205     4204       -1     
Files Changed Coverage Δ
...ain/java/com/cloud/api/query/QueryManagerImpl.java 3.03% <0.00%> (ø)
...n/java/com/cloud/api/query/ViewResponseHelper.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weizhouapache weizhouapache merged commit 19aacad into apache:4.18 Aug 15, 2023
@DaanHoogland DaanHoogland deleted the showIsoUrls branch August 15, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants