UI unit test: expected values#7792
Merged
weizhouapache merged 1 commit intoapache:4.18from Jul 31, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.18 #7792 +/- ##
============================================
+ Coverage 13.02% 13.43% +0.41%
- Complexity 9030 9394 +364
============================================
Files 2720 2747 +27
Lines 257001 258844 +1843
Branches 40083 40313 +230
============================================
+ Hits 33463 34779 +1316
- Misses 219337 219685 +348
- Partials 4201 4380 +179 see 104 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
soreana
approved these changes
Jul 31, 2023
weizhouapache
approved these changes
Jul 31, 2023
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
manually tested ok
not sure if there is regression
Member
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
There was a problem hiding this comment.
LGTM, build passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a failure in UI unit tests
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?