server: remove registered userdata when cleanup an account

[weizhouapache]

Description

This PR fixes the leftover of userdata when delete an account

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6576

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7180)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48649 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7777-t7180-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_list_vms_metrics_admin	Error	3610.18	test_metrics_api.py
test_list_vms_metrics_history	Error	5.45	test_metrics_api.py
test_list_volumes_metrics_history	Error	5.55	test_metrics_api.py
test_01_migrate_VM_and_root_volume	Error	83.86	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	54.51	test_vm_life_cycle.py

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[harikrishna-patnala]

Since account cleanup involves cleaning the templates and VMs, removing the userdata should also be fine.

Code LGTM

[blueorangutan]

[SF] Trillian test result (tid-7193)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44769 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7777-t7193-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	78.82	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	52.34	test_vm_life_cycle.py

[DaanHoogland]

@blueorangutan test keepEnv

[DaanHoogland]

will test manually, but maybe we should have a cleanup marvin test (for accounts but also domains)?

[yadvr]

LGTM haven't tested it

[DaanHoogland]

tests good