Conversation
|
@blueorangutan package |
|
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
DaanHoogland
left a comment
There was a problem hiding this comment.
quite a great effort. I wouldn't mind this excpet that the removed licenses are probably not acceptable in apache by-laws. Also can you justify this chance with a bit more text, please?
| @@ -1,51 +1,10 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
removing the license is not acceptable in apache foundation policy
There was a problem hiding this comment.
fixed, also added to all new java classes
|
Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 1437 |
| @@ -0,0 +1,84 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
This backup file can be excluded
| @@ -0,0 +1,32 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
this backup file can be excluded
| @@ -0,0 +1,32 @@ | |||
| <!-- | |||
|
@Akvel thanks for joining in, can you add some context for us to understand your morives behind this PR, please? Especially because it is not eliminating the XML completely, what are we gaining going ahead with this? |
@DaanHoogland I am converted beans that can be easily converted by scripts. I think this PR could be first step to Java-based configuration in all project. |
|
thanks @Akvel can you add that explanation to the description of the PR, please? |
done |
|
Thanks for the PR @Akvel. I liked the proposal. |
|
@DaanHoogland will test it out soon |
|
Hi @${author}, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch? |
|
@Akvel et al, closing this one as it has conflicts and is old. please update and reopen if you think it is still relevant. |
Description
This PR convert Spring XML based configurations to Java-Configurations.
Converted beans that can be easily converted by scripts. I think this PR could be first step to Java-based configuration in all project.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
mvn test