Skip to content

Display last updated time for VM#4685

Merged
yadvr merged 2 commits intoapache:mainfrom
ravening:vm-update-time
Aug 9, 2021
Merged

Display last updated time for VM#4685
yadvr merged 2 commits intoapache:mainfrom
ravening:vm-update-time

Conversation

@ravening
Copy link
Copy Markdown
Member

Description

Add a field in api response and ui to display last updated time

(local) mgt01 > list virtualmachinesmetrics filter=lastupdated,
{
  "count": 1,
  "virtualmachine": [
    {
      "lastupdated": "2021-02-10T15:43:14+0000"
    }
  ]
}
(local) mgt01 > list virtualmachines filter=lastupdated,
{
  "count": 1,
  "virtualmachine": [
    {
      "lastupdated": "2021-02-10T15:43:14+0000"
    }
  ]
}

Screenshot 2021-02-11 at 15 08 59

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2688

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2703

@shwstppr
Copy link
Copy Markdown
Contributor

@ravening conflict here

@shwstppr shwstppr added this to the 4.16.0.0 milestone Feb 15, 2021
@shwstppr
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2729

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tested with simulator

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2730

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Mar 6, 2021

@ravening pl fix the conflict

@sureshanaparti
Copy link
Copy Markdown
Contributor

ping @ravening can you resolve the conflicts

Add a field in api response and ui to display last updated time
@ravening
Copy link
Copy Markdown
Member Author

@ravening pl fix the conflict

@rhtyd @sureshanaparti fixed it

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 686

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1412)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55891 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4685-t1412-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 87 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_invalid_upgrade_kubernetes_cluster Failure 3605.06 test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster Failure 3163.62 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.18 test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster Failure 0.07 test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 88.67 test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 470.43 test_vpc_redundant.py
test_05_rvpc_multi_tiers Failure 476.52 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 476.53 test_vpc_redundant.py

Copy link
Copy Markdown
Contributor

@RodrigoDLopez RodrigoDLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change request.

private Date created;

@SerializedName("lastupdated")
@Param(description="the date when this virtual machine was updated last time")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes request: add since on this new parameter.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added and checked.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 9, 2021

Tests LGTM, failures not related to this PR.

@yadvr yadvr merged commit 949cf71 into apache:main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants