Use ACPI event to reboot VM on KVM, and Use 'forced' reboot option to stop and start the VM(s) by sureshanaparti · Pull Request #4681 · apache/cloudstack

sureshanaparti · 2021-02-11T08:04:30Z

Description

Use ACPI event to reboot VM on KVM, and Use 'forced' reboot option to stop and start the VM(s).

This PR addresses the following:

Replaces the legacy stop/start logic to reboot VM on KVM, with libvirt's native reboot operation that will use ACPI event based rebooting.
Introduces new 'forced' parameter in the rebootVirtualMachine API, which facilitates to stop and start the user VM.
Introduces new 'forced' parameter in rebootSystemVm API, to stop and start the system VM.
Introduces new 'forced' parameter in rebootRouter API, to force stop and start the Router.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

Reboot Dialog with Force option in the UI:

How Has This Been Tested?

Deployed a VM (on KVM / VMware 6.7.0 / XenServer 7.0), and Performed normal Reboot.
Deployed a VM (on KVM / VMware 6.7.0 / XenServer 7.0), and Performed force Reboot.
Marvin Tests for User VM, System VM and Router force reboot.

sureshanaparti · 2021-02-11T08:14:44Z

@blueorangutan package

blueorangutan · 2021-02-11T08:16:10Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2021-02-11T08:44:33Z

ui/src/config/section/compute.js

          show: (record) => { return ['Running'].includes(record.state) },
          args: (record, store) => {
            var fields = []
+            fields.push('forced')


@sureshanaparti what about systemvms, VR?

@sureshanaparti what about systemvms, VR?

The reboot for systemVMs and VR are performed using rebootSystemVm and rebootRouter APIs respectively, should add support for these as well ?

Added 'forced' reboot option for System VM and Router, as well. Existing reboot router operation already stops and starts the router, so the new 'forced' flag, would force stop and then start the router.

yadvr · 2021-02-11T08:45:19Z

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

        }
-        UserVm userVm = rebootVirtualMachine(CallContext.current().getCallingUserId(), vmId, enterSetup == null ? false : cmd.getBootIntoSetup());
+
+        UserVm userVm = rebootVirtualMachine(CallContext.current().getCallingUserId(), vmId, enterSetup == null ? false : cmd.getBootIntoSetup(), cmd.isForced());


@sureshanaparti does forced parameter cause it to perform a stop/start at orchestration level?

yadvr · 2021-02-11T08:48:23Z

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

+
+            if (forced) {
+                Host vmOnHost = _hostDao.findById(vm.getHostId());
+                if (vmOnHost == null || vmOnHost.getResourceState() != ResourceState.Enabled || vmOnHost.getStatus() != Status.Up ) {


@sureshanaparti is this a new behaviour, did it use to throw exception/fail when host is not enabled or up without forced=true?

@rhtyd Start VM can fail (or) either pick another host when the VM's host is not Enabled / not Up. As the force reboot stops and starts the VM, there are chances that start VM would fail in that case, and so it's safe to not allow when force reboot when host is not Enabled / not Up.

yadvr

Some minor comments, testing required, otherwise LGTM.

yadvr · 2021-02-11T08:49:10Z

@sureshanaparti is rebooting VM with forced=true|false covered in VM lifecycle smoketests?

blueorangutan · 2021-02-11T08:59:26Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2675

sureshanaparti · 2021-02-11T10:50:57Z

@sureshanaparti is rebooting VM with forced=true|false covered in VM lifecycle smoketests?

no, existing test(s) should cover forced=false, will add test(s) for forced=true.

sureshanaparti · 2021-02-12T05:34:25Z

@blueorangutan package

blueorangutan · 2021-02-12T05:35:14Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-02-12T06:12:30Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2679

…ent, and Added 'forced' reboot option to stop and start the VM (using rebootVirtualMachine API)

- New parameter 'forced' in rebootSystemVm API, to stop and then start System VM - New parameter 'forced' in rebootRouter API, to force stop and then start Router

sureshanaparti · 2021-02-17T06:15:31Z

@blueorangutan package

blueorangutan · 2021-02-17T06:16:35Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

sureshanaparti · 2021-02-17T06:16:39Z

@sureshanaparti is rebooting VM with forced=true|false covered in VM lifecycle smoketests?

no, existing test(s) should cover forced=false, will add test(s) for forced=true.

@rhtyd Added tests to cover reboot with forced=true, for User VM, System VM and Router.

blueorangutan · 2021-02-17T07:05:50Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2719

sureshanaparti · 2021-02-17T16:08:36Z

@blueorangutan package

blueorangutan · 2021-02-17T16:09:42Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-02-17T16:46:40Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2726

sureshanaparti · 2021-02-17T18:01:45Z

@blueorangutan test matrix

blueorangutan · 2021-02-17T18:02:43Z

@sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2021-02-18T04:58:18Z

Trillian test result (tid-3566)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37807 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4681-t3566-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	779.21	test_kubernetes_clusters.py

yadvr · 2021-02-24T12:18:39Z

@blueorangutan package

blueorangutan · 2021-02-24T12:19:07Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-02-24T13:28:15Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2821

yadvr · 2021-02-25T16:55:38Z

@borisstoyanov are you lgtm on this?
@blueorangutan test

blueorangutan · 2021-02-25T16:56:17Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-02-26T02:26:52Z

Trillian test result (tid-3619)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32387 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4681-t3619-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	59.21	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	51.15	test_vm_life_cycle.py

yadvr · 2021-03-06T09:28:48Z

Bobby has confirmed manual testing. LGTM, let's merge.

sureshanaparti mentioned this pull request Feb 11, 2021

kvm: use ACPI and signal based reboot on KVM #4528

Closed

12 tasks

yadvr added this to the 4.15.1.0 milestone Feb 11, 2021

yadvr reviewed Feb 11, 2021

View reviewed changes

yadvr approved these changes Feb 11, 2021

View reviewed changes

yadvr modified the milestones: 4.15.1.0, 4.16.0.0 Feb 11, 2021

sureshanaparti marked this pull request as draft February 12, 2021 05:10

sureshanaparti changed the title ~~Use ACPI event to reboot VM on KVM, and Use 'forced' reboot option to stop and start the VM~~ Use ACPI event to reboot VM on KVM, and Use 'forced' reboot option to stop and start the VM(s) Feb 12, 2021

sureshanaparti force-pushed the cs-kvm-libvirt-acpi-reboot-and-forced-reboot branch from 68f6906 to 5c2c8c9 Compare February 12, 2021 05:33

sureshanaparti self-assigned this Feb 12, 2021

sureshanaparti added 3 commits February 12, 2021 16:14

Updated libvirt's native reboot operation for VM on KVM using ACPI ev…

66679e2

…ent, and Added 'forced' reboot option to stop and start the VM (using rebootVirtualMachine API)

Added 'forced' reboot option for System VM and Router

bf9d576

- New parameter 'forced' in rebootSystemVm API, to stop and then start System VM - New parameter 'forced' in rebootRouter API, to force stop and then start Router

Added force reboot tests for User VM, System VM and Router

c66d297

sureshanaparti force-pushed the cs-kvm-libvirt-acpi-reboot-and-forced-reboot branch from 5c2c8c9 to c66d297 Compare February 17, 2021 06:11

sureshanaparti marked this pull request as ready for review February 17, 2021 06:17

shwstppr added the type:enhancement label Feb 18, 2021

yadvr requested a review from borisstoyanov February 25, 2021 16:55

yadvr merged commit 81dfcbb into apache:master Mar 6, 2021

Conversation

sureshanaparti commented Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

sureshanaparti commented Feb 11, 2021

Uh oh!

blueorangutan commented Feb 11, 2021

Uh oh!

yadvr Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

yadvr Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

yadvr Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Feb 11, 2021

Uh oh!

blueorangutan commented Feb 11, 2021

Uh oh!

sureshanaparti commented Feb 11, 2021

Uh oh!

sureshanaparti commented Feb 12, 2021

Uh oh!

blueorangutan commented Feb 12, 2021

Uh oh!

blueorangutan commented Feb 12, 2021

Uh oh!

sureshanaparti commented Feb 17, 2021

Uh oh!

blueorangutan commented Feb 17, 2021

Uh oh!

sureshanaparti commented Feb 17, 2021

Uh oh!

blueorangutan commented Feb 17, 2021

Uh oh!

sureshanaparti commented Feb 17, 2021

Uh oh!

blueorangutan commented Feb 17, 2021

Uh oh!

blueorangutan commented Feb 17, 2021

Uh oh!

sureshanaparti commented Feb 17, 2021

Uh oh!

blueorangutan commented Feb 17, 2021

Uh oh!

blueorangutan commented Feb 18, 2021

Uh oh!

yadvr commented Feb 24, 2021

Uh oh!

blueorangutan commented Feb 24, 2021

Uh oh!

blueorangutan commented Feb 24, 2021

Uh oh!

yadvr commented Feb 25, 2021

Uh oh!

sureshanaparti commented Feb 11, 2021 •

edited

Loading

sureshanaparti Feb 11, 2021 •

edited

Loading