Display proper error message while deleting networks#4642
Display proper error message while deleting networks#4642ravening wants to merge 1 commit intoapache:mainfrom
Conversation
Display exception message if the networks cant be deleted
|
This method has usage in 5 different manager implementations:
As this changes the semantics of the call it needs thorough validation in all those components. |
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2640 |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
| return false; | ||
| final String message = "Can't delete the network, not all user vms are expunged. Vm " + vm + " is in " + vm.getState() + " state"; | ||
| s_logger.warn(message); | ||
| throw new InvalidParameterValueException(message); |
There was a problem hiding this comment.
Throwing exceptions will cause other issues here, as already mentioned by Daan, other components are handling the boolean response either by logging error message or cleaning up some other resources upon error (AccountManagerImpl).
There was a problem hiding this comment.
Throwing exceptions will cause other issues here, as already mentioned by Daan, other components are handling the boolean response either by logging error message or cleaning up some other resources upon error (AccountManagerImpl).
@ravening any update?
|
Trillian test result (tid-3479)
|
7 participants
Description
Display exception message if the networks cant be deleted
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?