You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some servers (like microsoft) are deprecating TLSv1 and TLSv1.1.
On Quota's mailing settings, ACS uses the protocol TLSv1; therefore, operators do not have options to choose which version they want to use.
This PR intends to externalize the protocol setting on Quota's mailing.
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Major
Minor
How Has This Been Tested?
It has been tested locally on a test lab.
I had Enabled Quota's plugin on the management server and configured it to use Gmail's SMTP server.
server address: smtp.gmail.com
username: gmail address
password: gmail password
port (TLS): 587
On Quota - All Accounts, I added 10 credits to my user and set 20 as min balance.
I had added an gmail address to Accounts > <account> > Users - Email.
I allowed Less secure app access on my Google account.
I had restarted management server.
And I called quota update API via Cloudmonkey.
In Gmail, we have an option to show original message, which provides the TLS version and the cipher. So I changed the configuration some times and sent some alerts to verify if both versions, in configuration and gmail, are the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some servers (like microsoft) are deprecating TLSv1 and TLSv1.1.
On Quota's mailing settings, ACS uses the protocol
TLSv1; therefore, operators do not have options to choose which version they want to use.This PR intends to externalize the protocol setting on Quota's mailing.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
It has been tested locally on a test lab.
On
Quota - All Accounts, I added 10 credits to my user and set 20 as min balance.I had added an gmail address to Accounts > <account> > Users - Email.
I allowed
Less secure app accesson my Google account.I had restarted management server.
And I called
quota updateAPI via Cloudmonkey.In Gmail, we have an option to
show originalmessage, which provides the TLS version and the cipher. So I changed the configuration some times and sent some alerts to verify if both versions, in configuration and gmail, are the same.