Skip to content

Externalize TLS version on Quota's mailing#4583

Merged
DaanHoogland merged 1 commit intoapache:masterfrom
GutoVeronezi:externalize-tls-version-on-quota-mailing
Feb 24, 2021
Merged

Externalize TLS version on Quota's mailing#4583
DaanHoogland merged 1 commit intoapache:masterfrom
GutoVeronezi:externalize-tls-version-on-quota-mailing

Conversation

@GutoVeronezi
Copy link
Copy Markdown
Contributor

Description

Some servers (like microsoft) are deprecating TLSv1 and TLSv1.1.

On Quota's mailing settings, ACS uses the protocol TLSv1; therefore, operators do not have options to choose which version they want to use.

This PR intends to externalize the protocol setting on Quota's mailing.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

It has been tested locally on a test lab.

  1. I had Enabled Quota's plugin on the management server and configured it to use Gmail's SMTP server.
server address: smtp.gmail.com
username: gmail address
password: gmail password
port (TLS): 587
  1. On Quota - All Accounts, I added 10 credits to my user and set 20 as min balance.

  2. I had added an gmail address to Accounts > <account> > Users - Email.

  3. I allowed Less secure app access on my Google account.

  4. I had restarted management server.

  5. And I called quota update API via Cloudmonkey.

  6. In Gmail, we have an option to show original message, which provides the TLS version and the cipher. So I changed the configuration some times and sent some alerts to verify if both versions, in configuration and gmail, are the same.

@DaanHoogland DaanHoogland added this to the 4.16.0.0 milestone Jan 18, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 19, 2021

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2753

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2772

@DaanHoogland
Copy link
Copy Markdown
Contributor

not sure if smoke tests touch this but
@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3599)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34235 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4583-t3599-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit 3177118 into apache:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants