Fixed create template from snapshot never returning#4005
Merged
andrijapanicsb merged 1 commit intoapache:4.13from Apr 1, 2020
Merged
Fixed create template from snapshot never returning#4005andrijapanicsb merged 1 commit intoapache:4.13from
andrijapanicsb merged 1 commit intoapache:4.13from
Conversation
Contributor
Author
|
@blueorangutan package |
|
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔debian. JID-1112 |
Contributor
|
LGTM manually tested on multiple snaps--> templates - GUI shows job completed properly as soon as it's finished. good work, thx @Spaceman1984 |
andrijapanicsb
approved these changes
Apr 1, 2020
Contributor
|
A very simple change, tested x2, not need for regression automated tests as it's a simple JS change merging based on ^^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When creating a template from a snapshot, the notification is not updated after the task is completed.
This PR fixes the issue.
Fixes: #3711
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
This has been tested by creating a template from a volume snapshot from the UI