Skip to content

Fixes raw templates not downloading#3993

Merged
andrijapanicsb merged 1 commit intoapache:4.13from
shapeblue:raw-file-addition
Mar 27, 2020
Merged

Fixes raw templates not downloading#3993
andrijapanicsb merged 1 commit intoapache:4.13from
shapeblue:raw-file-addition

Conversation

@Spaceman1984
Copy link
Copy Markdown
Contributor

Description

This PR fixes an error where raw template files are not being downloaded

Fixes: #2820

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This was tested by adding a raw template to be downloaded from the UI

@Spaceman1984
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1096

@Spaceman1984 Spaceman1984 changed the title Fix raw templates not being downloaded Fixes raw templates not downloading Mar 26, 2020
@DaanHoogland
Copy link
Copy Markdown
Contributor

testing, very risk poor change (downloading/image store only.

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1326)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26195 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3993-t1326-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 167.82 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 167.85 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 224.70 test_privategw_acl.py

@andrijapanicsb
Copy link
Copy Markdown
Contributor

LGTM

Tested with http://download.cloudstack.org/testing/CentOS-7-x86_64-GenericCloud-1511.raw.bz2 (temp abuse of the hosting, due to lack of availability of raw.bz2 images online on plain HTTP)

Works fine, downloaded, unpacked, and eventually Ready.
image

image

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and code lgtm

@andrijapanicsb
Copy link
Copy Markdown
Contributor

2 x approvals, automated regression tests fine, manual (fix) tests fine.

Merging based on ^^^

@andrijapanicsb andrijapanicsb merged commit 809dc33 into apache:4.13 Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants