Skip to content

server: export full response view for zones response for root admin#3989

Merged
yadvr merged 1 commit intoapache:4.13from
shapeblue:zone-resp-fix
Mar 25, 2020
Merged

server: export full response view for zones response for root admin#3989
yadvr merged 1 commit intoapache:4.13from
shapeblue:zone-resp-fix

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Mar 24, 2020

The listZonesMetrics does not return same keys are listZones as the
default response view is restricted. This fixes that by ensuring that
for root admin full response view is used.

This is critical to be merged for Primate tech preview.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Testing: http://primate-qa.cloudstack.cloud:8080/client/master

…oot admin

The listZonesMetrics does not return same keys are listZones as the
default response view is restricted. This fixes that by ensuring that
for root admin full response view is used.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.13.1.0 milestone Mar 24, 2020
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Mar 24, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1084

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Mar 24, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link
Copy Markdown
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have similar code with other admin apis.
no idea why this does not work.

anyway, this change looks good to me.

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1295)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26835 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3989-t1295-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 172.51 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 170.44 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 225.90 test_privategw_acl.py

@yadvr yadvr merged commit 2e3390f into apache:4.13 Mar 25, 2020
@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1311)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 146691 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3989-t1311-xenserver-65sp1.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 270.34 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 226.77 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 344.91 test_privategw_acl.py

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1315)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 206433 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3989-t1315-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 211.81 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 172.95 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 276.78 test_privategw_acl.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants