Skip to content

Updated upgrade path#3971

Merged
andrijapanicsb merged 2 commits intoapache:4.13from
shapeblue:update-db-upgrade-4.13.1.0
Mar 24, 2020
Merged

Updated upgrade path#3971
andrijapanicsb merged 2 commits intoapache:4.13from
shapeblue:update-db-upgrade-4.13.1.0

Conversation

@Spaceman1984
Copy link
Copy Markdown
Contributor

Description

This PR adds the 4.13.0.0 to 4.13.1.0 upgrade path

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This has been tested by starting up the client and checking the version table in the db.

@Spaceman1984
Copy link
Copy Markdown
Contributor Author

Spaceman1984 commented Mar 17, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1061

@DaanHoogland DaanHoogland added this to the 4.13.1.0 milestone Mar 17, 2020
@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1254)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26822 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3971-t1254-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 180.24 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 178.13 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 229.62 test_privategw_acl.py

@DaanHoogland DaanHoogland requested a review from yadvr March 18, 2020 08:25
@Spaceman1984
Copy link
Copy Markdown
Contributor Author

Spaceman1984 commented Mar 18, 2020

I have tested this upgrade path like this:

  • Install Cloudstack version 4.13
  • Create an instance on an isolated network in an advanced zone.
  • Point Cloudstack yum repo to new packages
  • Update Cloudstack to 4.13.1.0 (yum update)
  • Restart management server
  • Create a new instance
  • Restart the VR

Copy link
Copy Markdown
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

2020-03-24 12:28:06,703 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) DB version = 4.13.0.0 Code Version = 4.13.1.0
2020-03-24 12:28:06,704 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Database upgrade must be performed from 4.13.0.0 to 4.13.1.0
2020-03-24 12:28:06,712 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41300to41310 to upgrade from 4.13.0.0-4.13.1.0 to 4.13.1.0
2020-03-24 12:28:06,727 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Cleanup upgrade Upgrade41300to41310 to upgrade from 4.13.0.0-4.13.1.0 to 4.13.1.0
2020-03-24 12:28:06,740 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Upgrade completed for version 4.13.1.0

@andrijapanicsb
Copy link
Copy Markdown
Contributor

tests passing, 2 x LGTMS - merging

@andrijapanicsb andrijapanicsb merged commit e9b652a into apache:4.13 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants