Skip to content

server: password is not displayed when reinstall a vm or reset ssh key#3948

Merged
DaanHoogland merged 1 commit intoapache:4.13from
ustcweizhou:4.13-fix-password-reinstall-vm
Mar 12, 2020
Merged

server: password is not displayed when reinstall a vm or reset ssh key#3948
DaanHoogland merged 1 commit intoapache:4.13from
ustcweizhou:4.13-fix-password-reinstall-vm

Conversation

@ustcweizhou
Copy link
Copy Markdown
Contributor

Description

After reinstall a stopped vm or reset ssh key, the password is reset, and new password is saved in virtual router (if it is running). However we do not get any password in the api response as well as cloudstack UI.

This fixes the issue above.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@ustcweizhou
Copy link
Copy Markdown
Contributor Author

@rhtyd this seems to be caused by acc5fdc
could you please review it ?

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Mar 8, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1026

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm. compared to acc5fdc it makes sense. not tested

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1215)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27006 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3948-t1215-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 169.91 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 169.67 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 231.84 test_privategw_acl.py

@DaanHoogland DaanHoogland requested review from yadvr and removed request for yadvr March 10, 2020 08:58
@Spaceman1984
Copy link
Copy Markdown
Contributor

Tested LGTM.

@Spaceman1984
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1228)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28096 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3948-t1228-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 187.83 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 185.43 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 264.79 test_privategw_acl.py

@DaanHoogland DaanHoogland merged commit 19fb237 into apache:4.13 Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants