server: fix database exception while searching network offerings#3947
Merged
DaanHoogland merged 1 commit intoapache:4.13from Mar 6, 2020
Merged
server: fix database exception while searching network offerings#3947DaanHoogland merged 1 commit intoapache:4.13from
DaanHoogland merged 1 commit intoapache:4.13from
Conversation
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
weizhouapache
approved these changes
Mar 6, 2020
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
tested ok.
exception happened while list network offering with keyword
it is fixed with this pr
DaanHoogland
approved these changes
Mar 6, 2020
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
a one line change in a 280 line-method :( looks good other places the JoinVO ius used as well
Member
Author
|
The http://primate-qa.cloudstack.cloud:8080/client/ has the fix now, we tested on the UI ticket as well. |
DaanHoogland
added a commit
that referenced
this pull request
Mar 6, 2020
* 4.13: server: fix database exception while searching network offerings (#3947)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes db exception when network offering is searched. Found during Primate testing: apache/cloudstack-primate#186
Types of changes