server: use host record related to a ssvm/cpvm#3876
Merged
yadvr merged 1 commit intoapache:4.13from Feb 10, 2020
Merged
Conversation
This implements the systemvm list API response creator to find and use the host record for a ssvm/cpvm to get the agent status and other details like last disconnected date and agent version. Fixes 3875 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-795 |
Member
Author
Member
|
@rhtyd tested ok. Just a question, why did you replace lastping with disconnected in response ? we can keep both. |
Member
Author
|
@weizhouapache that value is not updated in the DB, in my test it always was |
shwstppr
approved these changes
Feb 10, 2020
Contributor
shwstppr
left a comment
There was a problem hiding this comment.
LGTM based on code changes and API response
Contributor
|
LGTM |
Member
@rhtyd oh yes. cloud service does not send PingCommand to management server every minute. |
weizhouapache
approved these changes
Feb 10, 2020
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
This implements the systemvm list API response creator to find and use the host record for a ssvm/cpvm to get the agent status and other details like last disconnected date and agent version. Fixes 3875 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This implements the systemvm list API response creator to find and use
the host record for a ssvm/cpvm to get the agent status and other
details like last disconnected date and agent version.
Fixes #3875
Signed-off-by: Rohit Yadav rohit.yadav@shapeblue.com
Description
Types of changes