Skip to content

systemvmtemplate: Fix Debian 9 iso url#3582

Merged
yadvr merged 1 commit intoapache:4.13from
dpassante:fix/4.11/debian9_iso_url
Sep 10, 2019
Merged

systemvmtemplate: Fix Debian 9 iso url#3582
yadvr merged 1 commit intoapache:4.13from
dpassante:fix/4.11/debian9_iso_url

Conversation

@dpassante
Copy link
Copy Markdown
Contributor

@dpassante dpassante commented Sep 4, 2019

Description

Since version 10.0.0 of Debian has become stable, the URL of the Debian 9.9.0 ISO files has changed from current to archive.

The old URL returns a 404 and crash the build of systemvm templates.

Affects: 4.11, 4.13.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

I built a systemvm template without any errors with this change.

Copy link
Copy Markdown
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Checksum still matches

Copy link
Copy Markdown
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabrielBrascher
Copy link
Copy Markdown
Member

@dpassante thanks for this PR. Can you please target this change to branch 4.13?
The current LTS is (will be soon released) 4.13.0.0. Or does it make sense add this to 4.11 and then push forward from 4.11 ➡️ 4.13 ➡️ master @wido @PaulAngus @rhtyd?

@svenvogel
Copy link
Copy Markdown
Contributor

it always the same if the iso will change. i think we have any of this PRs in the past. its lesser a bug more than a normal change :)

@dpassante dpassante force-pushed the fix/4.11/debian9_iso_url branch from e341880 to a2d4d09 Compare September 10, 2019 06:37
@dpassante dpassante changed the base branch from 4.11 to 4.13 September 10, 2019 06:38
@dpassante
Copy link
Copy Markdown
Contributor Author

@GabrielBrascher Done !
If the 4.13 will be soon released as the new TLS, it probably doesn't make sense to add this small fix to 4.11.

@dpassante
Copy link
Copy Markdown
Contributor Author

The CI ran on 4.11 branch when I rebased the PR. I probably should have changed the target branch before rebasing.
How can we get CI run again on 4.13 branch?

@yadvr yadvr added this to the 4.13.1.0 milestone Sep 10, 2019
@yadvr yadvr merged commit d43b499 into apache:4.13 Sep 10, 2019
@dpassante dpassante deleted the fix/4.11/debian9_iso_url branch September 10, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants