service is-active output check for "failed"

[DaanHoogland]

Description

small change to check for the right output of the system call

Fixes: #3572

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

manual testing on a nested env so far.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-267

[DaanHoogland]

@blueorangutan test centos7 kvm-centos7

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

Did not test but makes sense

[GabrielBrascher]

LGTM based on code and manual test.

I have tested and indeed the systemctl is-active cloudstack-management.service command returns active and failed. Regardless of calling a systemctl is-active cloudstack-management.service or systemctl is-failed cloudstack-management.service I got active and failed (that I found weird)

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-268

[DaanHoogland]

@blueorangutan test centos7 kvm-centos7

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-345)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38805 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3574-t345-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_10_destroy_cpvm	Error	951.72	test_ssvm.py
test_05_rvpc_multi_tiers	Failure	425.99	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	452.47	test_vpc_redundant.py

[DaanHoogland]

I'll have a quick look at those logs but I don't think these blueorangutan/Trillian errors are related to this change.
We'll have to decide if this goes on an lts or in master btw. it was created to master before the recent 4.13 release and as it is a bugfix I think it should go in there... ? @PaulAngus @GabrielBrascher @rhtyd @borisstoyanov ?