Remove unused config consoleproxy.cmd.port#12807
Remove unused config consoleproxy.cmd.port#12807sureshanaparti wants to merge 2 commits intoapache:4.22from
Conversation
|
@blueorangutan package |
There was a problem hiding this comment.
Pull request overview
This PR aims to remove the legacy/unused global setting consoleproxy.cmd.port as part of the 4.22.0.0 → 4.22.1.0 schema upgrade, to avoid exposing a misleading configuration option.
Changes:
- Adds a DB migration step to delete
consoleproxy.cmd.portfromcloud.configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12807 +/- ##
============================================
- Coverage 17.60% 17.60% -0.01%
Complexity 15677 15677
============================================
Files 5918 5918
Lines 531681 531680 -1
Branches 65005 65005
============================================
- Hits 93623 93620 -3
Misses 427498 427498
- Partials 10560 10562 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17126 |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
8dbb5d0 to
bc12ec5
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17241 |
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, will be hard to prove completeness, but at least some manual regression testing will be needed.
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
bc12ec5 to
e337f91
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17340 |
Description
This PR removes unused config 'consoleproxy.cmd.port'.
The config 'consoleproxy.cmd.port' reference is removed in 4.11.1.0 here: #2562. Before 4.11.1.0, it is referenced but not used -
cloudstack/server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
Lines 1246 to 1247 in b923c22
Fixes #11615
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?