Skip to content

noVNC: Show a dot cursor when the cursor is not visible#11418

Merged
sureshanaparti merged 1 commit intoapache:mainfrom
shapeblue:novnc-show-dot
Aug 11, 2025
Merged

noVNC: Show a dot cursor when the cursor is not visible#11418
sureshanaparti merged 1 commit intoapache:mainfrom
shapeblue:novnc-show-dot

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Aug 8, 2025

Description

When a VM doesn't provide a local cursor, or provides a fully-transparent (invisible) cursor, a dot is shown in the noVNC console after this change.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

The dot in the red box in below image
Screenshot From 2025-08-08 15-52-43

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a dot cursor display option to the noVNC console URL when viewing VMs that don't provide a local cursor or have invisible cursors. This improves user experience by providing visual feedback about cursor position when the VM's cursor is not visible.

  • Adds show_dot=true parameter to the noVNC console URL

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan package

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.35%. Comparing base (7d59bfe) to head (5d040ea).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...udstack/consoleproxy/ConsoleAccessManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11418      +/-   ##
============================================
- Coverage     17.35%   17.35%   -0.01%     
+ Complexity    15232    15229       -3     
============================================
  Files          5885     5885              
  Lines        525618   525618              
  Branches      64157    64157              
============================================
- Hits          91225    91213      -12     
- Misses       424094   424109      +15     
+ Partials      10299    10296       -3     
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RosiKyu RosiKyu self-assigned this Aug 8, 2025
@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14582

Copy link
Copy Markdown
Collaborator

@RosiKyu RosiKyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested and verified the fix.

A dot cursor is displayed if cursor is not visible.

PXL_20250808_144046286~2

@vishesh92
Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-14046)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50120 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11418-t14046-kvm-ol8.zip
Smoke tests completed. 145 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_list_cpvm_vm Failure 0.05 test_ssvm.py
test_04_cpvm_internals Failure 0.04 test_ssvm.py

@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Aug 11, 2025
@sureshanaparti sureshanaparti merged commit 1994511 into apache:main Aug 11, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Aug 11, 2025
@DaanHoogland DaanHoogland deleted the novnc-show-dot branch August 11, 2025 15:15
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants