Skip to content

Fix edit of compute offering in UI#11417

Merged
sureshanaparti merged 1 commit intoapache:mainfrom
shapeblue:fix-ui-compute-offering-edit
Aug 11, 2025
Merged

Fix edit of compute offering in UI#11417
sureshanaparti merged 1 commit intoapache:mainfrom
shapeblue:fix-ui-compute-offering-edit

Conversation

@vishesh92
Copy link
Copy Markdown
Member

Description

This PR fixes #11416

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Copy Markdown
Member Author

@blueorangutan ui

@vishesh92 vishesh92 added this to the 4.21.0 milestone Aug 8, 2025
@vishesh92 vishesh92 requested a review from Copilot August 8, 2025 08:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a typo in the UI configuration for editing compute offerings, specifically correcting a misspelled parameter name in the arguments array.

  • Corrects the typo from 'storageatags' to 'storagetags' in the edit action configuration

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.35%. Comparing base (7d59bfe) to head (7e11685).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11417      +/-   ##
============================================
- Coverage     17.35%   17.35%   -0.01%     
+ Complexity    15232    15227       -5     
============================================
  Files          5885     5885              
  Lines        525618   525618              
  Branches      64157    64157              
============================================
- Hits          91225    91205      -20     
- Misses       424094   424116      +22     
+ Partials      10299    10297       -2     
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11417 (QA-JID-726)

@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14581

Copy link
Copy Markdown
Collaborator

@RosiKyu RosiKyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested and verified the fix

Compute offerings can be edited in the UI.

Screencast.from.2025-08-08.17-24-53.webm
image

@DaanHoogland
Copy link
Copy Markdown
Contributor

@sureshanaparti , will you merge this ?

@sureshanaparti sureshanaparti merged commit 26218b0 into apache:main Aug 11, 2025
25 checks passed
@sureshanaparti sureshanaparti deleted the fix-ui-compute-offering-edit branch August 11, 2025 10:56
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Unable to edit service offerings in UI

7 participants