UI: Prevent exceptions when network service provider that's disabled is viewed#11413
UI: Prevent exceptions when network service provider that's disabled is viewed#11413DaanHoogland merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11413 +/- ##
============================================
- Coverage 17.35% 17.35% -0.01%
+ Complexity 15232 15230 -2
============================================
Files 5885 5885
Lines 525618 525632 +14
Branches 64157 64161 +4
============================================
- Hits 91225 91216 -9
- Misses 424094 424120 +26
+ Partials 10299 10296 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@Pearl1594 is this only applicable on main? |
|
testing this in qa: |
@Pearl1594 can you check/fix this? |
|
@Pearl1594 With the changes, when I clicked on Nsx, Netris, Tungsten, nothing happens (old view remains as is), at least show message indicating the plugin is disabled, or hide all the disabled providers. |
|
The provider should appear disabled i.e., in red - which should be an indicator that it is disabled. As historically, we haven't explicitly prompted the user that a provider is disabled with any notification per se, which is why I continued with that behaviour. |
| } | ||
|
|
||
| try { | ||
| const providers = ['tungsten', 'nsx', 'netris'] |
There was a problem hiding this comment.
can this list be retrieved?
There was a problem hiding this comment.
you mean from the backend? I don't believe so that we have a way (API) to identify external network providers.
I mean, we can get the list of all network service providers, but not what needs a global setting to be enabled to actually use it.
|
@blueorangutan package |
|
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15430 |
|
@blueorangutan package |
|
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15435 |
RosiKyu
left a comment
RosiKyu
left a comment
There was a problem hiding this comment.
LGTM
Verified the fix for disabled external network providers (Tungsten, NSX, Netris).
- UI no longer throws errors when clicking on disabled providers.
- Top section updates correctly, and the table remains stable with no red toast.
- The previous F5-related error (listF5LoadBalancers) is no longer present as the plugin has been removed as per the referenced cleanup in #11463
Cross-browser tested on Chrome, Firefox, and Edge.
Screencast.from.2025-10-13.21-14-54.webm
6 participants
Description
This PR fixes these issues:
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?