Selected update traffic type based on chosen traffic type#10902
Merged
sureshanaparti merged 1 commit intoapache:mainfrom Jul 31, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10902 +/- ##
============================================
+ Coverage 16.49% 16.53% +0.03%
- Complexity 13705 13802 +97
============================================
Files 5708 5717 +9
Lines 504083 506306 +2223
Branches 61101 61440 +339
============================================
+ Hits 83139 83695 +556
- Misses 411665 413235 +1570
- Partials 9279 9376 +97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
RosiKyu
approved these changes
Jul 31, 2025
Collaborator
RosiKyu
left a comment
RosiKyu
left a comment
There was a problem hiding this comment.
LGTM.
With the fix:
- User selects "Management" traffic type → Update dialog shows "Management"
- User selects "Public" traffic type → Update dialog shows "Public"
- User selects "Storage" traffic type → Update dialog shows "Storage"
- User selects "Guest" traffic type → Update dialog shows "Guest"
Screencast.from.2025-07-31.12-33-00.webm
github-project-automation
bot
moved this from In Progress
to Done
in Apache CloudStack 4.21.0
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Aug 6, 2025
…ic types tab (apache#10902) Co-authored-by: Nicole Schmidt <nicole.schmidt@scclouds.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When selecting any traffic type and then clicking in the Update traffic type button the selected traffic type is always Guest. This PR changes this behavior to reflect the chosen traffic type value in the Traffic types tab.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
I confirmed that the traffic type value presented in the update traffic labels tab reflects the chosen traffic type before clicking on the button Update traffic labels.