UI: Fix Create dropdown menu not changing language dynamically #10023
UI: Fix Create dropdown menu not changing language dynamically #10023DaanHoogland merged 1 commit intoapache:4.20from
Create dropdown menu not changing language dynamically #10023Conversation
|
@lucas-a-martins thanks for the PR, is this only specific changes you've identified or is this a pattern across all of the UI config? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10023 +/- ##
=========================================
Coverage 15.98% 15.98%
Complexity 12753 12753
=========================================
Files 5631 5631
Lines 492702 492702
Branches 59737 59737
=========================================
Hits 78755 78755
Misses 405219 405219
Partials 8728 8728
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@rohityadavcloud this is the only case were I saw this happening, because this specific menu had it's translation defined in the |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM, Tested manually, the language changes for the create menu successfully
Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>
Description
This PR fixes the bug presented in the issue #10010, where the
Createdropdown menu language does not change dynamically, requiring a reload of the entire screen.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I tested the changes by setting the UI to a different language in the login screen and then changing to another after login, I also changed the language multiple times in the
Dashboardscreen. TheCreatemenu language changed every time as expected.