Merged
Conversation
* UI: Checkbox to make a newly added Network the default one in the Instance's Network tab * Fixed an issue that was causing exit from network tab after add-network
Contributor
Author
|
Could you check if its ok @abh1sar ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10022 +/- ##
============================================
- Coverage 15.98% 15.98% -0.01%
+ Complexity 12753 12752 -1
============================================
Files 5631 5631
Lines 492702 492715 +13
Branches 59737 59739 +2
============================================
- Hits 78755 78754 -1
- Misses 405219 405233 +14
Partials 8728 8728
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
@JoaoJandre |
abh1sar
approved these changes
Dec 2, 2024
Contributor
abh1sar
left a comment
abh1sar
left a comment
There was a problem hiding this comment.
Thanks for doing the back port @JoaoJandre
yadvr
approved these changes
Dec 3, 2024
Contributor
Author
|
@weizhouapache Ok, I'll do it like that next time |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Dec 12, 2024
…10022) * UI: Checkbox to make a newly added Network the default one in the Instance's Network tab * Fixed an issue that was causing exit from network tab after add-network Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports #9708 to 4.20
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?